-
Notifications
You must be signed in to change notification settings - Fork 20
Isotropic remeshing with feature edges #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
daniel-zint
wants to merge
37
commits into
main
Choose a base branch
from
fpir
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add sizing field and add per-patch target edge length 2. Add script for converting pkl to wmtk input 3. Change swap to use triangle quality instead of valence 4. Project vertices onto input surface.
…lkit into fpir * 'main' of https://github.com/wildmeshing/wildmeshing-toolkit: (37 commits) Fix is_vertex_on_boundary(). Add "is vertex on boundary" check and remove flag if boundary was collapsed away. Try to fix newton method + remove open boundary checks. Check if vertex is still on an open boundary after collapse. Fix boundary sample envelope. Fix envelope so that the exact one can also be used for the original TetWild. Add back all swap operations in TetWild. Remove debug output in TetWildMesh Fix issues in print methods of original TetWild. Replace .get() with .at() of AttributeCollection. Adding a parameter to the _energy functions for swaps. Minor fixes. Change 4-4 swap. It now has an energy function just like the 5-6 swap. Check AMIPS before collapse to avoid manifold check. Perform swap multiple times + format logging messages. Add energy function to 5-6 swap. Remove forgotten geogram include in original TetWild. Add 5-6 swap to TetWild. Add tests for 56 swap. Adding untested 5-6 swap operation. ... # Conflicts: # src/wmtk/envelope/Envelope.cpp
There is also a sanity check for feature edges that can be removed after sufficient testing. It should not have too much of a performance impact so maybe it can also just stay there.
…lkit into fpir * 'fpir' of https://github.com/wildmeshing/wildmeshing-toolkit: remove the edge 2 list of the remeshing # Conflicts: # app/remeshing/src/remeshing/UniformRemeshing.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.